Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implement "Big Bags" #4548

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[Feature] Implement "Big Bags" #4548

wants to merge 10 commits into from

Conversation

Kinglykrab
Copy link
Contributor

@Kinglykrab Kinglykrab commented Nov 22, 2024

Description

  • Implements bags up to 200 slots for ROF2 clients.

Disclaimer

  • Servers using older clients (pre-ROF2) will need to use the following query to limit all their bags to 10 bag slots so their servers still function properly.
UPDATE `items` SET `bagslots` = 10 WHERE `bagslots` > 10;

Type of change

  • Breaking change
  • This change requires a documentation update

Before and After Slot IDs

image

Testing

image
image
image
image
image

Clients tested: ROF2

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I have made corresponding changes to the documentation (if applicable, if not delete this line)
  • I own the changes of my code and take responsibility for the potential issues that occur
  • I have tested the changes on a local database and updated version.h CURRENT_BINARY_DATABASE_VERSION to the new version.

Credits

  • Thanks to @catapultam-habeo and @SecretsOTheP for sharing their bag implementations and allowing me to finalize a version for EQEmulator as a whole.

@crotonrz
Copy link

Thousands of players who don't follow server code, just got a semi...and they don't yet know why.

@Kinglykrab Kinglykrab marked this pull request as ready for review December 3, 2024 01:49
@MortimerGreenwald
Copy link
Contributor

MortimerGreenwald commented Dec 13, 2024

While testing got a query error see below:
Placing an item and removing an item in the Shared Bank Slots (both).
image
{90333CB6-0E4A-49AE-9345-32C1B8591171}

@MortimerGreenwald
Copy link
Contributor

Looking good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants