Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Revert 2df7d19 #4101

Merged
merged 3 commits into from
Feb 20, 2024
Merged

[Bug Fix] Revert 2df7d19 #4101

merged 3 commits into from
Feb 20, 2024

Conversation

joligario
Copy link
Contributor

The original change breaks lich-type spells as seen in #4098. Per comment on original change, also don't see where Runes come into play.

Current behavior immediately after casting invis:
image

Reverted behavior:
image

This change breaks lich-type spells as seen in #4098. Per comment on original change, also don't see where Runes come into play.
@joligario joligario requested a review from fryguy503 February 19, 2024 12:14
Correct the location of the CommonBreakInvis for runes. Appologize for the incorrect location. Thank you JJ for pointing me to the PR that caused the issue.
Copy link
Contributor Author

@joligario joligario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Akkadius Akkadius merged commit a99ce4f into master Feb 20, 2024
2 checks passed
@Akkadius Akkadius deleted the invis_break-revert branch February 20, 2024 04:35
@Akkadius Akkadius mentioned this pull request Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants