🐛 Fix the learning rate scale #60
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #60 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 71 71
Lines 3607 3608 +1
Branches 426 426
=======================================
+ Hits 3549 3550 +1
Misses 22 22
Partials 36 36
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Co-authored-by: hanruisong00 <[email protected]> Co-authored-by: Adrien Lafage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks again to @hanruisong00 for the remark. We have to discuss the best way to fix this scaling problem. The current solution is unsatisfactory as it scales all ensemble methods; however, BatchEnsembles and Masksembles should not be scaled according to their source code. Is the default automated scaling, and are BatchEnsembles/Masksembles anomalies? No, because MCDropout should not be scaled either. If it's 50/50, we could add a parameter to handle this question correctly.
Will resolve #59.