Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a bit more about spatial data #176

Merged
merged 4 commits into from
Nov 25, 2024
Merged

docs: add a bit more about spatial data #176

merged 4 commits into from
Nov 25, 2024

Conversation

maelle
Copy link
Collaborator

@maelle maelle commented Nov 5, 2024

WIP. TODOS

  • Align introductory vignette with README

@maelle maelle requested a review from salvafern November 5, 2024 14:06
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.33%. Comparing base (60ba8dc) to head (d9c2e2d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   93.31%   93.33%   +0.01%     
==========================================
  Files           9        9              
  Lines         359      360       +1     
==========================================
+ Hits          335      336       +1     
  Misses         24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@annakrystalli annakrystalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a shot at this @maelle !

I've made some suggestions to keep the language closer to WFS terminology and added some extra definitions that hopefully make it easier for folks unfamiliar with WFS to follow what's going on. It's a bit of a divergence to what we discussed last week (sorry!), but on revisiting and adding some definitions, it seemed more accurate and clear.

README.Rmd Outdated Show resolved Hide resolved
README.Rmd Outdated Show resolved Hide resolved
README.Rmd Outdated Show resolved Hide resolved
README.Rmd Outdated Show resolved Hide resolved
README.Rmd Outdated Show resolved Hide resolved
@@ -1,13 +1,20 @@
---
title: "Accessing and mapping EMODnet data"
output: rmarkdown::html_vignette
df_print: "tibble"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG this is so elegant and simple

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maelle
Copy link
Collaborator Author

maelle commented Nov 19, 2024

@annakrystalli thank you!!

@salvafern thank you!! I will port your edit to the .orig file and then knit it.

@salvafern
Copy link
Collaborator

salvafern commented Nov 22, 2024

I'm adding my review later today!
Ported the edits to .orig myself

salvafern added a commit to EMODnet/EMODnet-Biology-Guidance that referenced this pull request Nov 22, 2024
@salvafern salvafern marked this pull request as ready for review November 22, 2024 13:44
maelle and others added 4 commits November 25, 2024 08:41
Co-authored-by: Anna Krystalli <[email protected]>

Co-authored-by: Salvador Fernández Bejarano <[email protected]>
Co-authored-by: Anna Krystalli <[email protected]>

Co-authored-by: Salvador Fernández Bejarano <[email protected]>
Co-authored-by: Anna Krystalli <[email protected]>

Co-authored-by: Salvador Fernández Bejarano <[email protected]>
@maelle maelle merged commit a1d2f73 into main Nov 25, 2024
14 of 16 checks passed
@maelle maelle deleted the docs branch November 25, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants