-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add a bit more about spatial data #176
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
==========================================
+ Coverage 93.31% 93.33% +0.01%
==========================================
Files 9 9
Lines 359 360 +1
==========================================
+ Hits 335 336 +1
Misses 24 24 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a shot at this @maelle !
I've made some suggestions to keep the language closer to WFS terminology and added some extra definitions that hopefully make it easier for folks unfamiliar with WFS to follow what's going on. It's a bit of a divergence to what we discussed last week (sorry!), but on revisiting and adding some definitions, it seemed more accurate and clear.
@@ -1,13 +1,20 @@ | |||
--- | |||
title: "Accessing and mapping EMODnet data" | |||
output: rmarkdown::html_vignette | |||
df_print: "tibble" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMG this is so elegant and simple
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know right? And there are more options: https://pkgs.rstudio.com/rmarkdown/reference/output_format.html#arguments-1
@annakrystalli thank you!! @salvafern thank you!! I will port your edit to the .orig file and then knit it. |
I'm adding my review later today! |
Co-authored-by: Anna Krystalli <[email protected]> Co-authored-by: Salvador Fernández Bejarano <[email protected]>
Co-authored-by: Anna Krystalli <[email protected]> Co-authored-by: Salvador Fernández Bejarano <[email protected]>
Co-authored-by: Anna Krystalli <[email protected]> Co-authored-by: Salvador Fernández Bejarano <[email protected]>
d9c2e2d
to
6ea1571
Compare
WIP. TODOS