Tests for DataCollection #307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psomhorst
force-pushed
the
286_test_datacollection
branch
from
3fd942a to
99d93d8
Compare
psomhorst
force-pushed
the
286_test_datacollection
branch
2 times, most recently
from
bf4078a to
119524b
Compare
This was
linked to
issues
Oct 23, 2024
There was a problem hiding this comment.
@psomhorst I have reviewed the tests for data collection. I think in general it is very clear and comprehensive. I have a few small questions/ suggestions.
The omission of these line essentially disabled overwrite protection if the key was not explicitly given. As this is/was the default way to add items to a collection, the overwrite protection was essentially unused.
`obj in v.derived_from` uses equality (==) rather than identity (is).
psomhorst
force-pushed
the
286_test_datacollection
branch
from
c9b988e to
4a11e26
Compare
|
@JulietteFrancovich Thanks for your suggestions. I added the requested tests. |
JulietteFrancovich
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for
DataCollections were missing. Three issues withDataCollectionor data loading were found and fixed in this PR.The tests cover 95% of the code in datacollection.py. The
select_by_time()method is not tested forDataCollection[IntervalData]becauseselect_by_time()is not finalised forIntervalData. Created #306 to add this test when #198 is fixed.Closes #285 #286.