Skip to content

Commit

Permalink
ci: move linting to separate yml file
Browse files Browse the repository at this point in the history
and simplify the action, doesn't require installing the entire package.
  • Loading branch information
DaniBodor committed Jun 18, 2024
1 parent 051c504 commit b93a4e1
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 27 deletions.
27 changes: 0 additions & 27 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,33 +44,6 @@ jobs:
pytest -v ;
python${{ matrix.python-version }} -m build'
lint:
if: github.event.pull_request.draft == false
name: Linting build
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: ["ubuntu-latest"]
python-version: ["3.10"]
steps:
- uses: actions/checkout@v3
- name: Set up Python 3.10
uses: actions/setup-python@v3
with:
python-version: ${{ matrix.python-version }}
- name: Python info
shell: bash -l {0}
run: |
which python3
python3 --version
- name: Upgrade pip and install dependencies
run: |
python3 -m pip install --upgrade pip setuptools
python3 -m pip install .[dev,publishing]
- name: Check linting with ruff
run: ruff check .

coveralls:
if: github.event.pull_request.draft == false
name: Coveralls build
Expand Down
41 changes: 41 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
name: Linting

on:
push:
branches:
- main
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
paths-ignore:
- "**.md"
- "**.rst"
- "**.ipynb"
branches:
- main

jobs:
lint:
if: github.event.pull_request.draft == false
name: Linting
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: ["ubuntu-latest"]
python-version: ["3.10"]
steps:
- uses: actions/checkout@v3
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v3
with:
python-version: ${{ matrix.python-version }}
- name: Python info
shell: bash -l {0}
run: |
which python3
python3 --version
- name: Check linting and formatting using ruff
run: |
python3 -m pip install ruff
ruff check || echo "Please ensure you have the latest version of ruff (`ruff -V`) installed locally."
ruff format --check || echo "Please ensure you have the latest version of ruff (`ruff -V`) installed locally."

0 comments on commit b93a4e1

Please sign in to comment.