Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix imports #60

Merged
merged 1 commit into from
Jul 8, 2024
Merged

fix imports #60

merged 1 commit into from
Jul 8, 2024

Conversation

DaniBodor
Copy link
Member

I accidentally discovered that these imports were outdated.

For some reason the build workflow still worked despite these imports not being accurate. That is a bit concerning, isn't it?

@DaniBodor DaniBodor requested a review from wbaccinelli July 8, 2024 13:36
Copy link
Collaborator

@wbaccinelli wbaccinelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted! The type checking is not used for building, right? I guess that that's why it did not fail.

@DaniBodor
Copy link
Member Author

Well spotted! The type checking is not used for building, right? I guess that that's why it did not fail.

right, so we'd need to implement a static type checker for that. not sure we want to go there at this point.

@DaniBodor DaniBodor merged commit aca72e7 into main Jul 8, 2024
2 checks passed
@DaniBodor DaniBodor deleted the hotfix_imports_dbodor branch July 8, 2024 15:56
@wbaccinelli
Copy link
Collaborator

Well spotted! The type checking is not used for building, right? I guess that that's why it did not fail.

right, so we'd need to implement a static type checker for that. not sure we want to go there at this point.

Let's leave it be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants