-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: use ruff instead of prospector #28
Conversation
To be checked the PathLib issue |
056e650
to
08be6f5
Compare
Could you please test it again on the last commit, and if that doesn't work on the commit before (1dbf35f). Semi-related to this: is the |
I tried on both the commits, but I get the same error. The problem was that the with Path the output was not a string but a path object an this is not accepted by the some of the dash core components. I am pushing the changes.
Yes, it is used when you click "parent directory" in the popup. Unfortunately, with Dash it's not easy to retrieve immediately if a callback function is actually used, because it is not directly referenced in the code, but it's triggered when the input in the decorator is changed. |
b5d2648
to
e51f1a7
Compare
Thanks! I squashed the three commits regarding pathlib into a single commit as they together fixed a single thing. |
@wbaccinelli , I still need you to approve the PR before I can merge :) |
and format the file.
for some reason we need to cast these to str to make it work on some systems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it works :)
.vscode/settings.json
Outdated
"notebook.lineNumbers": "on", | ||
"notebook.formatOnSave.enabled": true, | ||
"notebook.codeActionsOnSave": { | ||
"notebook.source.fixAll": "explicit" | ||
}, | ||
"notebook.diff.ignoreMetadata": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can get rid of this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed. I removed it from that commit.
0f62ce7
to
0ad4b43
Compare
No description provided.