-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
019 functional load page wbaccinelli #23
Conversation
Hey @wbaccinelli , any reason this PR is still a draft or can do you want me to review it? |
I'm getting the following error after selecting the file to load:
|
At the moment we are not using the |
this is a temporary change and should be moved back to main when that branch is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, works well!
nice, works well! The CI is failing because in eitprocessing we are restructuring the way data is handled is not what the tests are currently expecting. As the branch in eitprocessing is still work in progress and likely to change again, there is no reason to make the tests work now we will leave it as is. |
Fixes #19
The Load page is now functional and it uses the new version of the eitprocessing.
The continuous data are currently displayed, but not saved in the selection.
Note that while the newest branch of eitprocessing is still being updated, it's better to run the dashboard from a conda env rather than from poetry