Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

019 functional load page wbaccinelli #23

Merged
merged 14 commits into from
Feb 23, 2024

Conversation

wbaccinelli
Copy link
Collaborator

@wbaccinelli wbaccinelli commented Jan 31, 2024

Fixes #19

The Load page is now functional and it uses the new version of the eitprocessing.
The continuous data are currently displayed, but not saved in the selection.

Note that while the newest branch of eitprocessing is still being updated, it's better to run the dashboard from a conda env rather than from poetry

@DaniBodor
Copy link
Member

Hey @wbaccinelli , any reason this PR is still a draft or can do you want me to review it?

@wbaccinelli wbaccinelli marked this pull request as ready for review February 13, 2024 14:05
@DaniBodor
Copy link
Member

DaniBodor commented Feb 23, 2024

I'm getting the following error after selecting the file to load:

Traceback (most recent call last):
File "/home/dbodor/miniconda3/envs/dashalive/lib/python3.10/site-packages/eit_dash/callbacks/load_callbacks.py", line 134, in open_data_selector
eit_data, continuous_data, sparse_data = EITData.from_path(
File "/home/dbodor/miniconda3/envs/dashalive/lib/python3.10/site-packages/eitprocessing/eit_data/init.py", line 100, in from_path
loaded_data = vendor_class._from_path( # pylint: disable=protected-access
File "/home/dbodor/miniconda3/envs/dashalive/lib/python3.10/site-packages/eitprocessing/eit_data/draeger.py", line 124, in _from_path
) = cls._convert_medibus_data(medibus_data, time)
File "/home/dbodor/miniconda3/envs/dashalive/lib/python3.10/site-packages/eitprocessing/eit_data/draeger.py", line 139, in _convert_medibus_data
continuous_data = ContinuousData(
TypeError: ContinuousData.init() missing 1 required positional argument: 'category'

@wbaccinelli
Copy link
Collaborator Author

At the moment we are not using the eitprocessing from the main branch, because we need the refactored version from this branch. Therefore, to run the dashboard is now needed either to change the pyptoject.toml file and set the rev to the refactoring branch, or to create a conda env and install the eitprocessing package from the refactoring branch.

this is a temporary change and should be moved back to main when that branch is merged
Copy link
Member

@DaniBodor DaniBodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, works well!

@DaniBodor
Copy link
Member

nice, works well!

The CI is failing because in eitprocessing we are restructuring the way data is handled is not what the tests are currently expecting. As the branch in eitprocessing is still work in progress and likely to change again, there is no reason to make the tests work now we will leave it as is.

@DaniBodor DaniBodor merged commit 84cf5d6 into main Feb 23, 2024
0 of 2 checks passed
@DaniBodor DaniBodor deleted the 019_functional_load_page_wbaccinelli branch February 23, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make load page functional
2 participants