Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WarpXInitEB: fix " int eb_update" shadowing "std::array< std::unique_ptr<amrex::iMultiFab>,3> & eb_update" #5591

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

lucafedeli88
Copy link
Member

This PR fixes the following issue:

/home/vsts/work/1/s/Source/EmbeddedBoundary/WarpXInitEB.cpp:366:25: warning: declaration of ‘int eb_update’ shadows a parameter [-Wshadow]
  366 |                     int eb_update = 1;
      |                         ^~~~~~~~~
/home/vsts/work/1/s/Source/EmbeddedBoundary/WarpXInitEB.cpp:296:56: note: shadowed declaration is here
  296 |     std::array< std::unique_ptr<amrex::iMultiFab>,3> & eb_update,
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~

Found in https://dev.azure.com/ECP-WarpX/WarpX/_build/results?buildId=20383&view=logs&j=8aa019fd-d859-51bf-081f-826e7fa9e37a

@lucafedeli88 lucafedeli88 added the cleaning Clean code, improve readability label Jan 22, 2025
@lucafedeli88 lucafedeli88 requested a review from RemiLehe January 22, 2025 11:03
@RemiLehe RemiLehe merged commit 6e4def5 into ECP-WarpX:development Jan 22, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning Clean code, improve readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants