Move ApplyBCKCorrection from WarpX header to anonymous namespace in WarpXFaceExtensions.cpp #5590
+152
−97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ApplyBCKCorrection(int idim);
is only used insideWarpXFaceExtensions.cpp
, therefore, with the aim of simplifying the WarpX class, this PR moves it to an anonymous namespace insideWarpXFaceExtensions.cpp
.The following modifications are also introduced:
idim
is now passed toApplyBCKCorrection
as a template parameter (in order to pass is as a template parameter toComputeSStab
, see below)ApplyBCKCorrection
calledComputeSStab
which was a free function insideWarpXFaceExtensions.cpp
, therefore the PR movesComputeSStab
to the anonymous namespaceComputeSStab
now takesidim
as a template parameter for performance reasons (avoid ifs inside the kernel)ComputeSStab
takingidim
as a non-template argument is also provided, in order to avoid extensive modifications in other parts ofWarpXFaceExtensions.cpp
WARPX_ALWAYS_ASSERT_WITH_MESSAGE
[[maybe_unused]]
attribute is added for the non-template version ofComputeSStab
to avoid unused function issues raised byAppleClang
andclang-tidy