EVA-3365 Filter by taxonomy when getting active contigs #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcezard
reviewed
Aug 23, 2023
Comment on lines
111
to
115
| private static List<Bson> buildAggregationForActiveContigs(String assemblyAccession, int taxonomyAccession) { | ||
| Bson match = Aggregates.match(Filters.and(Filters.eq(ACTIVE_REFERENCE_ASSEMBLY_FIELD, assemblyAccession), | ||
| Filters.eq(ACTIVE_REFERENCE_TAXONOMY_FIELD, taxonomyAccession))); |
There was a problem hiding this comment.
This aggregation applies to the clusteredVariantEntities but the taxonomy field is not really informative there.
The only reliable one is in the submittedVariantEntities.
|
Looks good! Will approve after CI is fixed. |
nitin-ebi
force-pushed
the
filter_by_tax
branch
from
b7590a9
to
a7edc5e
Compare
sundarvenkata-EBI
approved these changes
Aug 24, 2023
tcezard
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.