Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change nsec to sec #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

change nsec to sec #15

wants to merge 1 commit into from

Conversation

koki-ogura
Copy link

time unit of scan_time and time_increment must be second but nanosecond.

mibcat
mibcat approved these changes Aug 22, 2019
View reviewed changes
Copy link

@mibcat mibcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this will fix the issue

jonra1993
jonra1993 suggested changes Sep 3, 2019
View reviewed changes
Copy link

@jonra1993 jonra1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi I think that change can help to implement SLAM algorithms like cartographer easily.

@jonra1993 jonra1993 mentioned this pull request Nov 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonra1993 jonra1993 jonra1993 requested changes

@mibcat mibcat mibcat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koki-ogura @mibcat @jonra1993