Merge pull request #149 from Dynatrace/fix-nre-upload

fix NRE when uploading multiple dumps at once
Dynatrace · Dec 18, 2018 · b555d24 · b555d24
2 parents 98cec39 + f3b29dd
commit b555d24
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/SuperDumpService/Services/DumpRepository.cs b/src/SuperDumpService/Services/DumpRepository.cs
@@ -68,7 +68,6 @@ public IEnumerable<DumpMetainfo> GetAll() {
 		public async Task<DumpMetainfo> CreateDump(string bundleId, FileInfo sourcePath) {
 			DumpMetainfo dumpInfo;
 			string dumpId;
-			var dict = new ConcurrentDictionary<string, DumpMetainfo>();
 			dumpId = CreateUniqueDumpId();
 			dumpInfo = new DumpMetainfo() {
 				BundleId = bundleId,
@@ -78,8 +77,8 @@ public async Task<DumpMetainfo> CreateDump(string bundleId, FileInfo sourcePath)
 				Created = DateTime.Now,
 				Status = DumpStatus.Created
 			};
-			dict[dumpId] = dumpInfo;
-			dumps.TryAdd(bundleId, dict);
+			if (!dumps.ContainsKey(bundleId)) dumps[bundleId] = new ConcurrentDictionary<string, DumpMetainfo>();
+			dumps[bundleId][dumpId] = dumpInfo;
 			storage.Create(dumpInfo.Id);
 
 			FileInfo destFile = await storage.AddFileCopy(dumpInfo.Id, sourcePath);