Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decode/encode support for additional Intel cache management instructions. #7109

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

khuey
Copy link
Contributor

@khuey khuey commented Dec 7, 2024

This covers the CLWB/CLDEMOTE extensions and the previously omitted CLFLUSHOPT instruction.

Because these instructions explicitly forbid modrm.mod == 3 a sequence from the binutils tests that previously decoded as a nop but now would decode as a CLDEMOTE with modrm.mod == 3 is removed.

…uctions.

This covers the CLWB/CLDEMOTE extensions and the previously omitted CLFLUSHOPT instruction.

Because these instructions explicitly forbid modrm.mod == 3 a sequence from the
binutils tests that previously decoded as a nop but now would decode as a CLDEMOTE
with modrm.mod == 3 is removed.
@khuey khuey requested a review from derekbruening December 7, 2024 08:16
core/ir/x86/decode_table.c Show resolved Hide resolved
core/ir/x86/decode_table.c Show resolved Hide resolved
core/ir/x86/instr_create_api.h Show resolved Hide resolved
@derekbruening
Copy link
Contributor

Heads up that I noticed the fence opcodes with the wrong categories and am fixing in #7112 which if that goes in first may require manual conflict resolution as it's a line right next to clflush.

@khuey khuey merged commit e24dbb0 into master Dec 10, 2024
17 checks passed
@khuey khuey deleted the iX-cache-management-instrs branch December 10, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants