-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i#7055: Migrate actions runner image from macOS 12 to macOS 13. #7094
i#7055: Migrate actions runner image from macOS 12 to macOS 13. #7094
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for getting this working. I think we just want to avoid the nop LOG messages and checks and instead put the variables as DEBUG-only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meant to mark Approve since this probably doesn't need another look.
The macOS 12 Actions runner image will begin deprecation on 10/7/24 and will be fully unsupported by 12/3/24 for GitHub and ADO.
Please refer to actions/runner-images#10721 for details.
Updating the runner to macOS13 and DEVELOPER_DIR triggers unused-but-set-variable warnings.
Changed code to address unused-but-set-variable warnings by moving code under #ifdef, adding LOGs following CLIENT_ASSERT.
Fixes: #7055