Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#7046: Add register values to the output of X64 Linux dr_create_memory_dump(). #7088

Merged
merged 16 commits into from
Nov 22, 2024

Conversation

ivankyluk
Copy link
Contributor

@ivankyluk ivankyluk commented Nov 16, 2024

Add program header notes NT_PRSTATUS (prstatus structure) and NT_FPREGSET (floating point registers) to the output of X64 Linux dr_create_memory_dump().

Verify the output of code_api|client.memory_dump_test using "readelf -a" on x86 and ARM machines.

Issue: #7046

Copy link
Contributor

@derekbruening derekbruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to pass the dcontext/mcontext through to make this safe for non-client use and to generalize for registers in other threads.

core/unix/coredump.c Show resolved Hide resolved
core/unix/coredump.c Show resolved Hide resolved
core/unix/coredump.c Show resolved Hide resolved
core/unix/coredump.c Show resolved Hide resolved
core/unix/coredump.c Outdated Show resolved Hide resolved
core/unix/coredump.c Outdated Show resolved Hide resolved
core/CMakeLists.txt Show resolved Hide resolved
core/unix/coredump.c Outdated Show resolved Hide resolved
core/unix/coredump.c Outdated Show resolved Hide resolved
core/unix/coredump.c Show resolved Hide resolved
api/docs/release.dox Show resolved Hide resolved
api/docs/release.dox Show resolved Hide resolved
api/docs/release.dox Show resolved Hide resolved
core/unix/os_exports.h Outdated Show resolved Hide resolved
@ivankyluk ivankyluk merged commit 5e6429b into master Nov 22, 2024
17 checks passed
@ivankyluk ivankyluk deleted the i7046-add-register-values-to-memory-dump branch November 22, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants