i#6831 sched refactor, step 2: Split out scheduler_impl.cpp #7077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This first step toward separating key scheduler code into separate subclasses by mode of operation adds the pImpl idiom to the scheduler: the scheduler_t implementation is moved to a private class scheduler_impl_t, to let us (in a future step) create the appropriate subclass without changing callers who construct a scheduler_t. This also helps to split up and modularize the enormous scheduler class. A future step will move the scheduler_impl_t code into a new file scheduler_impl.cpp. That was separated out to make the diff easier to read here. The bulk of the changes involve: + The name change scheduler_tmpl_t to scheduler_impl_tmpl_t. + Having to qualify enum types as we do not have C++20's using enum. + Having to refer to types in another class now that the impl class is separate from the outer class. + Moving inlined routines out of scheduler.h now that the implementation is private and scheduler_impl_tmpl_t is an incomplete type in scheduler.h. + Some sched_type_t qualifications are removed due to new (private) using statements to make the code more readable. Issue: #6831
Moves the scheduler_impl_tmpl_t implementation out of scheduler.cpp and into a new file scheduler_impl.cpp. Issue: #6831
…heduler-impl-file
derekbruening
commented
Nov 12, 2024
abhinav92003
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the scheduler_impl_tmpl_t implementation out of scheduler.cpp and into a new file scheduler_impl.cpp.
Issue: #6831