-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to copy User App Data .addin files. #30
base: Revit2014
Are you sure you want to change the base?
Conversation
@ikeough I've got another pull request that builds on this one to ignore relative paths in Add-ins that I can submit if you agree to merge this one into the master branch. Thanks. |
var files = Directory.GetFiles(GetRevitUserAddinFolder()); | ||
foreach (var file in files) | ||
{ | ||
if (file.EndsWith(".addin", StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic is duplicated from the part above where we copy the addins. In the spirit of leaving the code cleaner than you found it, can you refactor this copy logic into a separate method and replace it here and above?
@vinnividivicci This is great! Thanks for the submission. I have just one small request above, then I'll merge it in. |
@ikeough Please see modifications made on this pull request: vinnividivicci#1 |
@vinnividivicci - Ian is out for this week. We will have someone take a look next week. Thanks for your submission. |
Did anyone ever take a look at this or has it been implemented some other way? |
I separated this feature out into a smaller commit.
Part of the solution to #28