add tests #53
add tests #53
Conversation
| @@ -3,7 +3,6 @@ | |||
| <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration> | |||
| <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform> | |||
| <PlatformTarget >x64</PlatformTarget> | |||
| <TargetFramework>net8.0</TargetFramework> | |||
There was a problem hiding this comment.
added targetframework to each project to be easier to understand
| Ex. open a command line in the DynamoSamples directory and run: | ||
| dotnet test %cd%\src\SampleLibraryTests -p:Configuration=Release - -filter "TestCategory!=Failure" - -logger "trx;LogFileName=results.trx" - -results-directory TestResults | ||
| Note: The - -filter, - -logger and - -results-directory should have double dashes without a space in between. --> | ||
| <SolutionDir>$(MSBuildThisFileDirectory)\</SolutionDir> |
| @@ -44,13 +44,15 @@ namespace SampleLibraryTests | |||
| class HelloDynamoZeroTouchTests : GeometricTestBase | |||
| { | |||
| [Test] | |||
| [Category("NEEDS_ASM")] | |||
There was a problem hiding this comment.
I am not sure we should call this ASM - maybe geo lib or something less ADSK speak.
There was a problem hiding this comment.
it looks good @pinzart90 - I did run into the issue I mentioned the other day again, some tests failing discovery because Dynamo's binaries are not around at discovery time.
This is especially an issue when writing tests for packages using AssemblyLoadContext isolation because there are likely conflicting dependencies with Dynamo and dumping your test binaries into the DynamoCore folder is going to put you right back into that mess.
I was curious if we have that filed somewhere? (not a blocker for merging this of course)
YEs, tracked internally DYN-6591 |
add automated tests