Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup Resources #1674

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Dec 20, 2024

  • fix the nullability of the inputs in one of the constructors
  • avoid the multiple enumerations of the inputs in 2 of the constructors
  • avoid 3x HashSet allocations for 2 of the constructors

Question: should the 3 properties be changes to be ISet instead of ICollection?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant