Persist claim issuers in server side sessions #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damianh
reviewed
Dec 9, 2024
damianh
approved these changes
Dec 9, 2024
|
This should work, but it would be possible to improve the optimization for the default issuer. All claims in a ClaimsIdentity from a remote authentication provider typically have the same issuer. For Saml2 it's the Entity Id of the Idp (e.g. "https://stubidp.sustainsys.com/Metadata"). For OIDC it's the issuer/authority (e.g. "https://demo.duendesoftware.com"). For storage in a DB I don't think it's an issue to store the same string for each claim. As far as I remember this code would not be used to store anything in a cookie. If that was the case. I would have tried to optimize further to keep the issuer string once somewhere. |
|
I believe this is only ever used to create the ticket data that gets stored in a server side session. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1546
@AndersAbel this came up in context of a support issue you worked where someone couldn't logout using saml and sustainsys, so I've added you as a reviewer if you have time - is this what you were hoping for?