Merge pull request #1635 from SimonCropp/remove-redundant-list-and-ex…

…pression-alloc-in-SecretValidator.ValidateAsync remove redundant list and expression alloc in SecretValidator.ValidateAsync
DuendeSoftware · Dec 10, 2024 · c5dbbf9 · c5dbbf9
2 parents f4f0478 + 0489e10
commit c5dbbf9
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/IdentityServer/Validation/Default/SecretValidator.cs b/src/IdentityServer/Validation/Default/SecretValidator.cs
@@ -43,11 +43,9 @@ public async Task<SecretValidationResult> ValidateAsync(IEnumerable<Secret> secr
     {
         var secretsArray = secrets as Secret[] ?? secrets.ToArray();
 
-        var expiredSecrets = secretsArray.Where(s => s.Expiration.HasExpired(_clock.UtcNow.UtcDateTime)).ToList();
-        if (expiredSecrets.Any())
+        foreach (var expired in secretsArray.Where(s => s.Expiration.HasExpired(_clock.UtcNow.UtcDateTime)))
         {
-            expiredSecrets.ForEach(
-                ex => _logger.LogInformation("Secret [{description}] is expired", ex.Description ?? "no description"));
+            _logger.LogInformation("Secret [{description}] is expired", expired.Description ?? "no description");
         }
 
         var currentSecrets = secretsArray.Where(s => !s.Expiration.HasExpired(_clock.UtcNow.UtcDateTime)).ToArray();