Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/auto scroll to current sesion #972

Merged

Conversation

hiroaki404
Copy link
Contributor

Issue

Overview (Required)

When the screen opens, it scrolls to the item with the current time. The timetablegrid also scrolls.

  • If it is a breaking time between sessions, it scrolls to the previous session.
  • If it is after the end of the day's sessions, it scrolls to the last session.
  • Allow the user to save their position when they perform a scroll operation.
  • I also created a ui test.

It does not retain the scroll position when returning from the grid view, but this is an existing issue. I will not take action this time.
I wanted to animate the scrolling, but it seemed to cause a nasty bug, so it is out of the scope of this PR.

The work has been made by @yjyoon-dev until the middle of the work. Thanks.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

I have changed the date and time in the system settings.

Before After
current_time_before.mp4
current_time.mp4

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 5, 2024 09:32 Inactive
Copy link

github-actions bot commented Sep 5, 2024

Snapshot diff report

File name Image
KaigiAppTest[KaigiAp
p - when app is star
ting - it should sho
w timetable items]_c
ompare.png
TimetableScreenTest[
TimetableScreen - wh
en the current datet
ime is 2024-09-13 11
-00 - it should show
an timetable item o
f the current time a
t 11-00]_compare.png
TimetableScreenTest[
TimetableScreen - wh
en the current datet
ime is 2024-09-12 23
-00 - switch to grid
timetable - it shou
ld not show an indic
ator of the current
time]_compare.png
TimetableScreenTest[
TimetableScreen - wh
en the current datet
ime is 2024-09-11 10
-00 - switch to grid
timetable - it shou
ld not show an indic
ator of the current
time]_compare.png
TimetableScreenTest[
TimetableScreen - wh
en the current datet
ime is 2024-09-13 11
-00 - switch to grid
timetable - it shou
ld show an indicator
of the current time
at 11-00]_compare.p
ng
TimetableScreenTest[
TimetableScreen - wh
en the current datet
ime is 2024-09-12 10
-30 - it should show
an timetable item o
f the current time a
t 10-30]_compare.png
TimetableScreenTest[
TimetableScreen - wh
en the current datet
ime is 2024-09-12 23
-00 - it should show
an timetable item o
f the current time a
t 23-00]_compare.png
TimetableScreenTest[
TimetableScreen - wh
en the current datet
ime is 2024-09-12 10
-30 - switch to grid
timetable - it shou
ld show an indicator
of the current time
at 10-30]_compare.p
ng
TimetableScreenTest[
TimetableScreen - wh
en the current datet
ime is 2024-09-11 10
-00 - it should show
an timetable item o
f the current time a
t 10-00]_compare.png

@hiroaki404
Copy link
Contributor Author

Sorry, the test was unexpected on the search screen. I will fix it.

@hiroaki404
Copy link
Contributor Author

I used Instant to group the listings. This especially affected the tablet screen. We have restored to grouping using hours and minutes.

@takahirom
Copy link
Member

Could you solve the conflict? 🙏

@hiroaki404 hiroaki404 force-pushed the feature/auto_scroll_to_current_sesion branch from b112b8a to 534984d Compare September 8, 2024 08:30
@hiroaki404
Copy link
Contributor Author

I noticed when I was merging that it scrolled down even if it wasn't the day of the conference. Please wait a little bit.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 8, 2024 08:34 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 8, 2024 09:01 Inactive
@hiroaki404
Copy link
Contributor Author

I fix probrem. Please review!

captureScreenWithChecks {
checkTimetableListDisplayed()
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Could we have a test for the grid timetable?

describe("when swiching to grid time table") {
  doIt {
...
  }
  itShould("show an timetable item of the current time at $xxx")
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a grid timetable test below that I'm trying to integrate, what do you think? I will change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. That sounds good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I change test. Please review!

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 10, 2024 00:39 Inactive
@takahirom
Copy link
Member

Looks great! Thank you for your contribution!

@takahirom takahirom merged commit cf4f87e into DroidKaigi:main Sep 12, 2024
7 checks passed
@hiroaki404 hiroaki404 deleted the feature/auto_scroll_to_current_sesion branch September 13, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll to current time session when opening the timetable
2 participants