-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/auto scroll to current sesion #972
Feature/auto scroll to current sesion #972
Conversation
Sorry, the test was unexpected on the search screen. I will fix it. |
I used Instant to group the listings. This especially affected the tablet screen. We have restored to grouping using hours and minutes. |
Could you solve the conflict? 🙏 |
b112b8a
to
534984d
Compare
I noticed when I was merging that it scrolled down even if it wasn't the day of the conference. Please wait a little bit. |
I fix probrem. Please review! |
captureScreenWithChecks { | ||
checkTimetableListDisplayed() | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Could we have a test for the grid timetable?
describe("when swiching to grid time table") {
doIt {
...
}
itShould("show an timetable item of the current time at $xxx")
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a grid timetable test below that I'm trying to integrate, what do you think? I will change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. That sounds good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I change test. Please review!
Looks great! Thank you for your contribution! |
Issue
Overview (Required)
When the screen opens, it scrolls to the item with the current time. The timetablegrid also scrolls.
It does not retain the scroll position when returning from the grid view, but this is an existing issue. I will not take action this time.
I wanted to animate the scrolling, but it seemed to cause a nasty bug, so it is out of the scope of this PR.
The work has been made by @yjyoon-dev until the middle of the work. Thanks.
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)
I have changed the date and time in the system settings.
current_time_before.mp4
current_time.mp4