♻️ [iOS & Android ContributorsScreen]Added loading indicator since it is missing. #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Detekt check failed. Please run |
Contributors Since it seems that Loading and Exists are not output to XCFrameWork when UiState is a sealed interface, I modified it like this.
Corvus400
changed the title
Corvus400
commented
Sep 3, 2024
Comment on lines
+52
to
+63
| sealed class ContributorsUiState { | ||
| abstract val userMessageStateHolder: UserMessageStateHolder | ||
| } | ||
|
|
||
| class Loading( | ||
| override val userMessageStateHolder: UserMessageStateHolder, | ||
| ) : ContributorsUiState() | ||
|
|
||
| class Exists( | ||
| override val userMessageStateHolder: UserMessageStateHolder, | ||
| val contributors: PersistentList<Contributor>, | ||
| val userMessageStateHolder: UserMessageStateHolder, | ||
| ) | ||
| ) : ContributorsUiState() |
There was a problem hiding this comment.
At first, UiState was configured with sealed interface, but since it is not included in XCFramework and cannot be referenced on the iOS side, it has been made into a sealed class and then into this form.
734b8b3#diff-dd1ff2a856844eaf95d9daf6c02a417e43b971fb53282a4d81e398b0a89ca639L52-L63
|
The indicator display on the iOS side cannot be confirmed because there is a problem where the contributor screen crashes when there is no network connection on the iOS side. 🙏 |
takahirom
approved these changes
Sep 4, 2024
![ContributorsScreenTest[ContributorsScreen - when server is operational - when server is down - when launch - it should does not show contributor and show snackbar]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_enhancement/implement_loading_ui_state_contributors_screen/./screenshot-diff-reports/feature/contributors/build/outputs/roborazzi/ContributorsScreenTest%5BContributorsScreen%20-%20when%20server%20is%20operational%20-%20when%20server%20is%20down%20-%20when%20launch%20-%20it%20should%20does%20not%20show%20contributor%20and%20show%20snackbar%5D_compare.png){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Movie (Optional)
before.android.mp4
after.android.mp4