Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Fixed a problem where the motion sensor would not work on iOS. #935

Merged
merged 3 commits into from
Sep 3, 2024
Merged

🔧 Fixed a problem where the motion sensor would not work on iOS. #935

merged 3 commits into from
Sep 3, 2024

Conversation

Corvus400
Copy link
Contributor

@Corvus400 Corvus400 commented Sep 3, 2024 •
edited
Loading

Issue

Overview (Required)

  • Because deviceMotionActive was being checked in places where deviceMotionAvailable should have been checked, there was a problem where the motion sensor would not work on iOS.

Movie (Optional)

Before | After

after2.mp4

@Corvus400
🔧 Because deviceMotionActive was being checked in places where device…
b468b86 
…MotionAvailable should have been checked, there was a problem where the motion sensor would not work on iOS.
@Corvus400
🔧 ./gradlew detekt --auto-correct
51e9aee
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 3, 2024 04:08 Inactive
@Corvus400 Corvus400 marked this pull request as ready for review September 3, 2024 04:40
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 3, 2024 05:14 Inactive
takahirom
takahirom approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for trying this! We need a sensor feature for the simulator. 😭

@takahirom takahirom merged commit 27e8386 into DroidKaigi:main Sep 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Motion Sensor Manager is not working on my iPhone.
2 participants
@Corvus400 @takahirom