Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump target sdk version to 35 #926

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Bump target sdk version to 35 #926

merged 2 commits into from
Sep 2, 2024
+8 −4

Conversation

NUmeroAndDev
Copy link
Contributor

@NUmeroAndDev NUmeroAndDev commented Sep 2, 2024 •
edited
Loading

Issue

  • close #ISSUE_NUMBER

Overview (Required)

  • Title says it all.
  • The oss-licenses-plugin has disabled Edge-to-Edge because it cannot control insets padding.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

No difference

Movie (Optional)

Before After

@NUmeroAndDev NUmeroAndDev self-assigned this Sep 2, 2024
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 2, 2024 03:42 Inactive
@NUmeroAndDev NUmeroAndDev marked this pull request as ready for review September 2, 2024 04:49
takahirom
takahirom approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I saw this tips in shibuya.apk. Thank you for using new API!

@takahirom takahirom merged commit 800a200 into DroidKaigi:main Sep 2, 2024
7 checks passed
@Corvus400
Copy link
Contributor

Corvus400 commented Sep 2, 2024 •
edited
Loading

@NUmeroAndDev @takahirom
If you run Gradle Sync, you should be prompted to install it, but I thought it might be hard to notice, so I made an announcement on X (Twitter). 🙏
https://x.com/Todayama_R/status/1830674922382963112
If this is too much of an intrusion, I apologize. 🙇

@NUmeroAndDev NUmeroAndDev deleted the bump_target_sdk_to_35 branch September 2, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees

@NUmeroAndDev NUmeroAndDev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NUmeroAndDev @Corvus400 @takahirom