Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 [iOS・Compose Multiplatform] The issue where the bottom navigation overlapped with the Create Profile button and made it difficult to press has been fixed. #925

Merged
merged 5 commits into from
Sep 3, 2024
Merged

🔧 [iOS・Compose Multiplatform] The issue where the bottom navigation overlapped with the Create Profile button and made it difficult to press has been fixed. #925

merged 5 commits into from
Sep 3, 2024
+6 −0

Conversation

Corvus400
Copy link
Contributor

@Corvus400 Corvus400 commented Sep 2, 2024 •
edited
Loading

Issue

Overview (Required)

  • I simply added 30.dp to the bottom.
  • As I mentioned in the comments, I think it would be better to get the inset from the iOS side as a permanent measure and set the padding in ProfileCardScreen based on that.

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before iPad mini After iPad mini
Before iPhone 15 After iPhone 15
Before iPhone SE 3rd gen After iPhone SE 3rd gen

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 2, 2024 02:42 Inactive
@Corvus400 Corvus400 changed the title 🔧 The issue where the bottom navigation overlapped with the Create Profile button and made it difficult to press has been fixed. 🔧 [iOS・Compose Multiplatform] The issue where the bottom navigation overlapped with the Create Profile button and made it difficult to press has been fixed. Sep 2, 2024
@Corvus400 Corvus400 marked this pull request as ready for review September 2, 2024 03:03
@Corvus400 Corvus400 requested a review from takahirom September 2, 2024 17:55
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 2, 2024 17:57 Inactive
@takahirom
Copy link
Member

Thank you for your contribution!

@takahirom takahirom merged commit 78b5b8a into DroidKaigi:main Sep 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom Awaiting requested review from takahirom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS・Compose Multiplatform] Bottom tab bar is covering create card button
2 participants
@Corvus400 @takahirom