Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 The problem of flickering icons has been addressed by caching ImageRequests. #923

Merged
merged 3 commits into from
Sep 2, 2024
Merged

🔧 The problem of flickering icons has been addressed by caching ImageRequests. #923

merged 3 commits into from
Sep 2, 2024

Conversation

Corvus400
Copy link
Contributor

@Corvus400 Corvus400 commented Sep 1, 2024 •
edited
Loading

Issue

Overview (Required)

  • Every time you scroll, a new ImageRequest instance was created using LocalContext.current.
  • As a result, rememberAsyncImagePainter would create a new Painter each time, causing flickering when scrolling.

Movie (Optional)

Before After
before.mp4

@Corvus400
🔧 The problem of flickering icons has been addressed by caching Image…
aa5c8a7 
…Requests.

Every time you scroll, a new ImageRequest instance was created using LocalContext.current.
As a result, rememberAsyncImagePainter would create a new Painter each time, causing flickering when scrolling.
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 1, 2024 23:28 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 1, 2024 23:34 Inactive
@Corvus400 Corvus400 marked this pull request as ready for review September 2, 2024 00:07
takahirom
takahirom approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for addressing this issue.

@takahirom takahirom merged commit 65ff982 into DroidKaigi:main Sep 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In TimetableScreen, SpearkerIcon blinks when offline and scrolling
2 participants
@Corvus400 @takahirom