Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed color of BottomNavigation and NavRail when Blur is not supported #913

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Changed color of BottomNavigation and NavRail when Blur is not supported #913

merged 1 commit into from
Sep 1, 2024
+78 −27

Conversation

kosenda
Copy link
Contributor

@kosenda kosenda commented Sep 1, 2024 •
edited
Loading

Issue

none

Overview (Required)

  • The appearance of BottomNavigation and NavRail on devices that do not support Blur and those that do is so different that we have made changes to make them look a little more similar.
  • The alpha value is set to a value that I feel is just right for me to touch.

Screenshot

orientation Before After SupportBlur
vertical
horizontal

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 1, 2024 07:50 Inactive
@kosenda kosenda marked this pull request as ready for review September 1, 2024 08:03
takahirom
takahirom approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks more natural! Thank you for your contribution!

@takahirom takahirom merged commit 4e84c61 into DroidKaigi:main Sep 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kosenda @takahirom