Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: concurrency strict warning in StaffReducer #565

Merged
merged 3 commits into from
Aug 18, 2024
Merged

Fix: concurrency strict warning in StaffReducer #565

merged 3 commits into from
Aug 18, 2024

Conversation

MrSmart00
Copy link
Contributor

@MrSmart00 MrSmart00 commented Aug 17, 2024 •
edited
Loading

Issue

Overview (Required)

  • Patch for a concurrency warning with Swift6 in StaffReducer

@MrSmart00 MrSmart00 marked this pull request as ready for review August 17, 2024 09:23
shin-usu
shin-usu approved these changes Aug 17, 2024
View reviewed changes
Copy link
Contributor

@shin-usu shin-usu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🎉🎊

@shin-usu
Copy link
Contributor

shin-usu commented Aug 17, 2024 •
edited
Loading

But I think issue431 should not be closed.
We have to fix other features, right?

@MrSmart00
Copy link
Contributor Author

@shin-usu
Thanks your rapid comment!

But I think issue431 should not be closed.
We have to fix other features, right?

Yes, this PR is proposal for concurrency support with TCA to us.
if the PR is merged, I'll fix others i think👍

@shin-usu
Copy link
Contributor

I'm glad I have same opinion!
Great PR, thanks😊

charles-b-stb
charles-b-stb approved these changes Aug 18, 2024
View reviewed changes
Copy link
Contributor

@charles-b-stb charles-b-stb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrSmart00 MrSmart00 self-assigned this Aug 18, 2024
@MrSmart00 MrSmart00 merged commit 05d2417 into main Aug 18, 2024
5 checks passed
@MrSmart00 MrSmart00 deleted the MrSmart00/feature/staff-concurrency-warning branch August 18, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shin-usu shin-usu shin-usu approved these changes

@charles-b-stb charles-b-stb charles-b-stb approved these changes

@ry-itto ry-itto Awaiting requested review from ry-itto

Assignees

@MrSmart00 MrSmart00

Labels
type:iOS 🍎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrSmart00 @shin-usu @charles-b-stb