[iOS] Replace the grid/list switching icon #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shin-usu
reviewed
Aug 16, 2024
Comment on lines
+75
to
+77
| Image(switchModeIcon) | ||
| .foregroundStyle(AssetColors.Surface.onSurface.swiftUIColor) | ||
| .frame(width: 40, height: 40) |
There was a problem hiding this comment.
The problem has not occurred because the original image color is onSurface, but I would expect that the color would not be changed unless the template is originally specified in the renderingMode modifier.
Suggested change
| Image(switchModeIcon) | |
| .foregroundStyle(AssetColors.Surface.onSurface.swiftUIColor) | |
| .frame(width: 40, height: 40) | |
| Image(switchModeIcon) | |
| .renderingMode(.template) | |
| .foregroundStyle(AssetColors.Surface.onSurface.swiftUIColor) | |
| .frame(width: 40, height: 40) |
I think it would be safer to add this one.
Alternatively, you can also set template-rendering-intent to imageset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)