Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine sponsor grid view #534

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Conversation

shimastripe
Copy link
Contributor

Issue

Overview (Required)

  • Use LazyVGrid in each sponsors section.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After
Simulator Screenshot - iPhone 15 Pro - 2024-08-16 at 23 51 48 Simulator Screenshot - iPhone 15 Pro - 2024-08-16 at 23 42 05
Simulator Screenshot - iPhone 15 Pro - 2024-08-16 at 23 51 50 Simulator Screenshot - iPhone 15 Pro - 2024-08-16 at 23 42 08

Movie (Optional)

Before After

}
}
}
makeSponsorGrid(columnCount: 2, items: store.golds, imageHeight: 77)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value ("77") is based on this PR.

Copy link
Contributor

@MrSmart00 MrSmart00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your commits🙏
LGTM!!!

Copy link
Contributor

@shin-usu shin-usu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🎉

@shin-usu shin-usu merged commit 4074a08 into DroidKaigi:main Aug 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Sponsor Feature: Apply the correct layout
3 participants