Impl bottom floating material glassed tabbar in iOS #483
Conversation
There was a problem hiding this comment.
LGTM!
But, please wait a review from @shin-usu about #483 (comment) 🙏🏼
There was a problem hiding this comment.
@shimastripe
Sorry for the late response 🙇🏻
I left some comments. Thanks!
| // bottom floating tabbar padding | ||
| Color.clear.padding(.bottom, 60) |
There was a problem hiding this comment.
TimetableView has list mode and grid mode, and user can switch each mode. (Grid mode is developing now)
Grid mode also has floating bottom tab, like list mode. Therefore, I think it would be appropriate for this code to be added to the TimetableView, not the TimetableListView,
There was a problem hiding this comment.
Yes, I understand your suggestion. However TimetableListView and TimetableGridView are ScrollView.
So if the padding is set in TimetableView, the scrollable area is above the floating tab bar.
There was a problem hiding this comment.
Okay, I understand.
It seems to be fine as it is👌🏻
Issue
Overview (Required)
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-08-15.at.20.39.24.mp4