Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: display session message #319

Merged

Conversation

kota-shiokara
Copy link
Contributor

Issue

Overview (Required)

  • Add a feature that display information when a value exists in TimetableItem.Session.message.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

@kota-shiokara
Copy link
Contributor Author

Since there is no "message" in the actual data, screenshots need to be done in Roborazzi where fake data can be used.
I'm not going smoothly with screenshots in Roborazzi now, so I created a PR in draft.

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 12, 2024 02:59 Inactive
Copy link

@takahirom
Copy link
Member

Looks great! Please make the pr ready!

@kota-shiokara
Copy link
Contributor Author

Sorry, the screenshot didn't work in the end.
Please check the output of GitHub Actions!

@kota-shiokara kota-shiokara marked this pull request as ready for review August 12, 2024 07:51
@takahirom
Copy link
Member

Thanks! This is better than what we have!

@takahirom takahirom merged commit 88418e6 into DroidKaigi:main Aug 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display session message feature for Android app
2 participants