Verify changing tab on Timetable screen #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ked4ma
changed the title
ked4ma
commented
Aug 11, 2024
| @@ -92,13 +93,20 @@ class TimetableScreenRobot @Inject constructor( | |||
| assert(clickedItems.isNotEmpty()) | |||
| } | |||
|
|
|||
| fun checkTimetableItemsDisplayed() { | |||
| fun checkTimetableListItemsDisplayed() { | |||
There was a problem hiding this comment.
I changed func name to distinguish with Grid one 🙏
ked4ma
commented
Aug 11, 2024
| @@ -51,7 +53,9 @@ fun TimetableDayTab( | |||
| tabs = { | |||
| DroidKaigi2024Day.visibleDays().forEach { conferenceDay -> | |||
| Tab( | |||
| modifier = Modifier.height(64.dp), | |||
| modifier = Modifier | |||
| .testTag(TimetableTabTestTag.plus(conferenceDay.dayIndex)) | |||
There was a problem hiding this comment.
To switch tab, add testTag to each tab with dayIndex.
(clickTimetableTab was already exist, so I adjusted enabling to use it)
ked4ma
commented
Aug 11, 2024
| @@ -100,6 +101,7 @@ fun TimetableGridItem( | |||
| } | |||
| Column( | |||
| modifier = modifier | |||
| .testTag(TimetableGridItemTestTag) | |||
There was a problem hiding this comment.
to check verify table item is displayed, added test tag to grid items.
ked4ma
changed the title
takahirom
approved these changes
Aug 11, 2024
![TimetableScreenTest[TimetableScreen - when server is operational - click conference day2 tab - it should change displayed day]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/add-timetable-test-screenshots-290/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20server%20is%20operational%20-%20click%20conference%20day2%20tab%20-%20it%20should%20change%20displayed%20day%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when server is operational - click timetable ui type change - click conference day2 tab - it should change displayed day]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/add-timetable-test-screenshots-290/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20server%20is%20operational%20-%20click%20timetable%20ui%20type%20change%20-%20click%20conference%20day2%20tab%20-%20it%20should%20change%20displayed%20day%5D_compare.png){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)