Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change transition area to cover entire card #295

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Change transition area to cover entire card #295

merged 2 commits into from
Aug 11, 2024

Conversation

CookieySun
Copy link
Contributor

Issue

Overview (Required)

  • Change transition area cover entire card.

Links

  • nothing

Screenshot (Optional if screenshot test is present or unrelated to UI)

nothing

Movie (Optional)

Before After
Screen_recording_20240811_201519.mp4
Screen_recording_20240811_201642.mp4

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 11, 2024 11:21 Inactive
@takahirom
Copy link
Member

Thank you for your pull request! Could you check the test?

io.github.droidkaigi.confsched.KaigiAppTest > runTest[KaigiApp - when app is starting - it should show timetable items] STANDARD_ERROR
    java.lang.AssertionError: Assert failed: The component is not displayed!

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 11, 2024 12:32 Inactive
@CookieySun
Copy link
Contributor Author

@takahirom I fixed test failed!

takahirom
takahirom approved these changes Aug 11, 2024
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The app should be much easy to use! Thanks!

@takahirom takahirom merged commit 911e8b8 into DroidKaigi:main Aug 11, 2024
5 checks passed
@CookieySun CookieySun deleted the feature/entire_card_tappable branch August 11, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timetable item tap area is too small
2 participants
@CookieySun @takahirom