Display appropriate information for Welcome Talk and Lunch Break in Timetable detail screen #284
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k in Timetable detail screen
hiraike32
commented
Aug 11, 2024
| @@ -79,7 +79,18 @@ fun TimetableItemDetailContent( | |||
| } | |||
|
|
|||
| is Special -> { | |||
| Text(stringResource(SessionsRes.string.special)) | |||
| DescriptionSection( | |||
There was a problem hiding this comment.
The content is displayed in the same way as in Session.
Please let me know if there is anything missing or incomplete.
There was a problem hiding this comment.
Thank you for letting me know. I think it is ok
|
Detekt check failed. Please run |
takahirom
approved these changes
Aug 11, 2024
![TimetableItemDetailScreenTest.runTest[TimetableItemDetailScreen - when server is operational - when launch - it should be appropriately accessible]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_issue-213/display-appropriate-information-on-special-contents/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableItemDetailScreenTest.runTest%5BTimetableItemDetailScreen%20-%20when%20server%20is%20operational%20-%20when%20launch%20-%20it%20should%20be%20appropriately%20accessible%5D_compare.png){kind=link}
![TimetableItemDetailScreenTest[TimetableItemDetailScreen - when server is operational - when launch - click bookmark - click bookmark again - it should show unbookmarked session]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_issue-213/display-appropriate-information-on-special-contents/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableItemDetailScreenTest%5BTimetableItemDetailScreen%20-%20when%20server%20is%20operational%20-%20when%20launch%20-%20click%20bookmark%20-%20click%20bookmark%20again%20-%20it%20should%20show%20unbookmarked%20session%5D_compare.png){kind=link}
![TimetableItemDetailScreenTest[TimetableItemDetailScreen - when server is operational - when launch - scroll - it should show scrolled session detail]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_issue-213/display-appropriate-information-on-special-contents/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableItemDetailScreenTest%5BTimetableItemDetailScreen%20-%20when%20server%20is%20operational%20-%20when%20launch%20-%20scroll%20-%20it%20should%20show%20scrolled%20session%20detail%5D_compare.png){kind=link}
![TimetableItemDetailScreenTest[TimetableItemDetailScreen - when server is operational - when launch - it should show session detail title]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_issue-213/display-appropriate-information-on-special-contents/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableItemDetailScreenTest%5BTimetableItemDetailScreen%20-%20when%20server%20is%20operational%20-%20when%20launch%20-%20it%20should%20show%20session%20detail%20title%5D_compare.png){kind=link}
![TimetableItemDetailScreenTest[TimetableItemDetailScreen - when server is operational - when launch - click bookmark - it should show bookmarked session]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_issue-213/display-appropriate-information-on-special-contents/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableItemDetailScreenTest%5BTimetableItemDetailScreen%20-%20when%20server%20is%20operational%20-%20when%20launch%20-%20click%20bookmark%20-%20it%20should%20show%20bookmarked%20session%5D_compare.png){kind=link}
![TimetableItemDetailScreenTest[TimetableItemDetailScreen - when server is operational - when font scale is small - it should show small font session detail]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_issue-213/display-appropriate-information-on-special-contents/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableItemDetailScreenTest%5BTimetableItemDetailScreen%20-%20when%20server%20is%20operational%20-%20when%20font%20scale%20is%20small%20-%20it%20should%20show%20small%20font%20session%20detail%5D_compare.png){kind=link}
hiraike32
deleted the
issue-213/display-appropriate-information-on-special-contents
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)