Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Added a 'View Map' text button to the About screen. #272

Merged
merged 4 commits into from
Aug 11, 2024
Merged

✨ Added a 'View Map' text button to the About screen. #272

merged 4 commits into from
Aug 11, 2024

Conversation

Corvus400
Copy link
Contributor

@Corvus400 Corvus400 commented Aug 11, 2024 •
edited
Loading

Issue

Overview (Required)

  • Added a 'View Map' text button to the About screen."

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After
None
add.view.map.mp4

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 11, 2024 05:12 Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 11, 2024 •
edited
Loading

Snapshot diff report

File name Image
AboutDroidKaigiDetai
lSummaryCardRowPrevi
ew_compare.png
AboutDroidKaigiDetai
lSummaryCardPreview_
compare.png
AboutDroidKaigiDetai
lPreview_compare.png
AboutScreenTest[Abou
tScreen - when launc
h - it should show d
etail section]_compa
re.png

@Corvus400 Corvus400 changed the title Feature/add map link Added a 'View Map' text button to the About screen." Aug 11, 2024
@Corvus400 Corvus400 marked this pull request as ready for review August 11, 2024 05:48
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 11, 2024 05:55 Inactive
takahirom
takahirom approved these changes Aug 11, 2024
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks as always! Looks great!
I'm looking forward to creating the app with you!

@takahirom takahirom merged commit 982d761 into DroidKaigi:main Aug 11, 2024
5 checks passed
@Corvus400 Corvus400 deleted the feature/add_map_link branch August 11, 2024 11:02
@Corvus400 Corvus400 changed the title Added a 'View Map' text button to the About screen." Added a 'View Map' text button to the About screen. Aug 11, 2024
@Corvus400 Corvus400 changed the title Added a 'View Map' text button to the About screen. ✨ Added a 'View Map' text button to the About screen. Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add map link for Bellesalle Shibuya Garden in About screen
2 participants
@Corvus400 @takahirom