Implement the app bar "About DroidKaigi" in the About list screen #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Snapshot diff report
|
|
I think it's better than nothing! If you don't mind, could |
Of course! I'll take care of it! |
takahirom
approved these changes
Aug 11, 2024
![AboutScreenTest[AboutScreen - when launch - it should show detail section]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/implement-app-bar-about-droidkaigi/./screenshot-diff-reports/feature/about/build/outputs/roborazzi/AboutScreenTest%5BAboutScreen%20-%20when%20launch%20-%20it%20should%20show%20detail%20section%5D_compare.png){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
TopAppBarLinks
Screenshot (Optional if screenshot test is present or unrelated to UI)
question
According to this figma, the
"About Droidkaigi"text in the App Bar seems to be fixed in the center when scrolling the screen.Should this feature be resolved in this PR? Should it be separated into a different issue?