Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor bug in tab bar and navigation bar #255

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

shin-usu
Copy link
Contributor

@shin-usu shin-usu commented Aug 10, 2024

Overview (Required)

  • Set tab bar color to black
  • Set navigation bar color to black
  • Add logic to back to root stack when tapping same tab

Movie (Optional)

Fix tab and navigation color

Before After
2024-08-11.1.42.30.mov

Logic that back to root stack

Before After
2024-08-11.1.42.13.mov

- Set navigation bar color
- Add logic to back to root stack when tapping same tab
}
)
) {
Group {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wrapped it in Group, I didn't change the content.

@shin-usu shin-usu marked this pull request as ready for review August 10, 2024 16:51
Copy link
Contributor

@MrSmart00 MrSmart00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Member

@ry-itto ry-itto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

@shin-usu shin-usu merged commit 2f6371e into main Aug 11, 2024
3 checks passed
@shin-usu shin-usu deleted the feature/minor_fix_tab_navigation_ios branch August 11, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants