Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sponsor feature with KMP #169

Merged
merged 6 commits into from
Jul 28, 2024
Merged

Add Sponsor feature with KMP #169

merged 6 commits into from
Jul 28, 2024

Conversation

MrSmart00
Copy link
Contributor

Issue

  • close #ISSUE_NUMBER

Overview (Required)

  • Add Sponsor item with KMP
    • This PR focus on KMP connection. so its layout is very lazy.
  • Update unit test

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

@MrSmart00 MrSmart00 marked this pull request as ready for review July 27, 2024 14:22
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR focus on KMP connection. so its layout is very lazy.

Copy link
Contributor

@charles-b-stb charles-b-stb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

state.golds = golds
state.supporters = supporters

print(state)
Copy link
Contributor

@shin-usu shin-usu Jul 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this print code left intentionally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!
I removed it👍

Copy link
Contributor

@shin-usu shin-usu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🍾

Copy link
Contributor

@charles-b-stb charles-b-stb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ry-itto ry-itto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MrSmart00 MrSmart00 merged commit ff9ec20 into main Jul 28, 2024
1 check passed
@MrSmart00 MrSmart00 deleted the MrSmart00/feature/sponsors branch July 28, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants