Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable apk distribution #152

Merged
merged 8 commits into from
Jul 25, 2024
Merged

enable apk distribution #152

merged 8 commits into from
Jul 25, 2024

Conversation

Yamada-Ika
Copy link
Contributor

@Yamada-Ika Yamada-Ika commented Jul 21, 2024

Issue

Overview (Required)

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

@Yamada-Ika Yamada-Ika self-assigned this Jul 21, 2024
Comment on lines +22 to +24
repository: droidkaigi/conference-app-2024
ref: gh-actions
path: gh-actions
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some usefull workflows in another branch. These workflows were created by jmatsu and modified by tomoya0x00.
https://github.com/DroidKaigi/conference-app-2024/tree/gh-actions

I updated dependencies and switched to using Node 20.

Comment on lines +33 to +37
- name: Download build outputs (APKs)
uses: actions/[email protected]
with:
name: build-outputs
path: ~/build-outputs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used actions/download-artifact instead of ./gh-actions/actions/get-artifact, but is there any issue?
I think it should be fine.

Copy link
Member

@takahirom takahirom Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with actions/download-artifact. Let's try using this!

api-token: ${{ secrets.DEPLOYGATE_API_TOKEN }}
app-owner-name: droidkaigi
platform: android
app-id: io.github.droidkaigi.confsched2023.dev
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think right now it's probably io.github.droidkaigi.confsched2023.dev, but I expect it will need to be renamed to io.github.droidkaigi.confsched2024.dev when the time comes. 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the package name! So we can now use io.github.droidkaigi.confsched2024.dev!
#154

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Fixed! 79fe1a1

@Yamada-Ika Yamada-Ika marked this pull request as ready for review July 21, 2024 16:28
@Yamada-Ika Yamada-Ika requested a review from a team July 21, 2024 16:28

- uses: ./.github/actions/setup-java

- run: ./gradlew :app-android:assemble --stacktrace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
For now, we don't want to spend a lot of build time because it could be costly, so how about using assembleDevDebug to specify the build variant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! Fixed!
b94b3be

@Yamada-Ika Yamada-Ika requested a review from takahirom July 22, 2024 17:32
@DroidKaigi DroidKaigi deleted a comment from github-actions bot Jul 23, 2024
@Yamada-Ika Yamada-Ika merged commit 935e4b6 into main Jul 25, 2024
5 checks passed
@Yamada-Ika Yamada-Ika deleted the yamada-ika/distribute-apk branch July 25, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload the app apk so that contributors can try the DroidKaigi App
2 participants