Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix first selected #143

Merged
merged 3 commits into from
Jul 27, 2024
Merged

fix first selected #143

merged 3 commits into from
Jul 27, 2024

Conversation

okayan
Copy link

@okayan okayan commented Jul 15, 2024

Issue

  • close #ISSUE_NUMBER

Overview (Required)

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

@takahirom
Copy link
Member

Great!
Please check out the conflicts in your free time 👍

Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Could you fix format and conflict problem?

@takahirom
Copy link
Member

takahirom commented Jul 19, 2024

I noticed your code style might not match our project's settings, particularly with the new line before =. Could you check our project's code style configuration in Android Studio and adjust accordingly?

@takahirom
Copy link
Member

I've fixed the conflict and format issues. Let me merge this. Thanks for your contribution!

@takahirom takahirom marked this pull request as ready for review July 27, 2024 03:40
@takahirom takahirom merged commit 6460fde into main Jul 27, 2024
5 checks passed
@takahirom takahirom deleted the feature/navigation_design_rough branch July 27, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants