Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed day buttons (missing data to do anything yet) #124

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Fixed day buttons (missing data to do anything yet) #124

merged 3 commits into from
Jul 19, 2024

Conversation

charles-b-stb
Copy link
Contributor

@charles-b-stb charles-b-stb commented Jul 13, 2024 •
edited
Loading

Android

Issue

Overview (Required)

  • Basic layout fixes. Still missing functionality for buttons
  • Top bar still works and has better buttons
  • Search button exists but does not do anything yet
  • missing date groupings (not in data yet)

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After
スクリーンショット 2024-06-25 23 07 52 スクリーンショット 2024-07-13 21 58 18

Movie (Optional)

Before After

@github-actions GitHub Actions
Copy link

Detekt check failed. Please run ./gradlew detekt --auto-correct to fix the issues.

@takahirom
Copy link
Member

@charles-b-stb
I noticed that your commits don't have an email address. It's your choice, but if you want to add yourself to the contributors' screen, you can add your email address that is registered with GitHub to the commit. 📮
git config --global user.email [email protected]

@charles-b-stb
Copy link
Contributor Author

I thought it was registered? I am a bit confused by that.

@charles-b-stb
Copy link
Contributor Author

Detekt check failed. Please run ./gradlew detekt --auto-correct to fix the issues.

I have run this multiple times and it fails every time? @takahirom

takahirom
takahirom reviewed Jul 19, 2024
View reviewed changes
...re/sessions/src/commonMain/kotlin/io/github/droidkaigi/confsched/sessions/TimetableScreen.kt Outdated
modifier = Modifier.background(Color.Black),
onClick = { /** TODO: Search here **/ },
) {
Text("Day 2", color = Color.Green$$)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem is this $$.

@github-actions GitHub Actions
Copy link

Snapshot diff report

File name Image
TimetableScreen - wh
en server is down -
it should show error
message_compare.png
TimetableScreen - wh
en server is operati
onal - click timetab
le ui type change -
it should change tim
etable ui type_compa
re.png
TimetableScreen - wh
en server is operati
onal - it should sho
w timetable items_co
mpare.png
TimetableScreen - wh
en server is operati
onal - click first s
ession bookmark - it
should show bookmar
ked session_compare.
png
KaigiAppTest.checkMe
diumTabletLaunchShot
_compare.png
KaigiAppTest.checkSt
artupShot_compare.pn
g

@takahirom takahirom marked this pull request as ready for review July 19, 2024 03:07
@takahirom
Copy link
Member

takahirom commented Jul 19, 2024 •
edited
Loading

Thanks for your contribution!
Let me merge this first.

@takahirom takahirom merged commit a016a03 into main Jul 19, 2024
4 checks passed
@takahirom takahirom deleted the feature/74-timetable-header-take2 branch July 19, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply timetable header and tab design roughly
2 participants
@charles-b-stb @takahirom