Added logic to add bookmark #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shin-usu
force-pushed
the
feature/add_bookmark
branch
2 times, most recently
from
8b66073 to
e2738cc
Compare
shin-usu
commented
Jul 11, 2024
Comment on lines
+7
to
+9
| streamTimetable: unimplemented("TimetableClient.streamTimetable"), | ||
| streamTimetableItemWithFavorite: unimplemented("TimetableClient.streamTimetableItemWithFavorite"), | ||
| toggleBookmark: unimplemented("TimetableClient.toggleBookmark") |
There was a problem hiding this comment.
Changed to use unimplemented as recommended in swift-dependencies libraries.
I changed to mock functions that are needed in unit tests.
https://pointfreeco.github.io/swift-dependencies/main/documentation/dependencies/livepreviewtest/#Test-value
shin-usu
force-pushed
the
feature/add_bookmark
branch
2 times, most recently
from
b699899 to
a871d00
Compare
shin-usu
force-pushed
the
feature/add_bookmark
branch
from
a871d00 to
d3acfea
Compare
MrSmart00
reviewed
Jul 12, 2024
Comment on lines
45
to
51
| do { | ||
| await send(.bookmarkResponse(.success( | ||
| try await timetableClient.toggleBookmark(id: TimetableItemId(value: "")) | ||
| ))) | ||
| } catch { | ||
| await send(.bookmarkResponse(.failure(error))) | ||
| } |
There was a problem hiding this comment.
Suggested change
| do { | |
| await send(.bookmarkResponse(.success( | |
| try await timetableClient.toggleBookmark(id: TimetableItemId(value: "")) | |
| ))) | |
| } catch { | |
| await send(.bookmarkResponse(.failure(error))) | |
| } | |
| await send(.bookmarkResponse(Result { | |
| try await timetableClient.toggleBookmark(id: TimetableItemId(value: "")) | |
| })) |
I guess you could change these like that🤔
There was a problem hiding this comment.
Yeah, it's smarter that way. Thx!
|
@MrSmart00 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview (Required)
Movie (Optional)
2024-07-12.1.21.12.mov