[iOS/Android] Updated room names inside app. #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pecially iOS). Data from the API has not been updated.
shin-usu
reviewed
Jul 10, 2024
| case .chipmunk: AssetColors.Custom.chipmunk.swiftUIColor | ||
| case .dolphin: AssetColors.Custom.dolphin.swiftUIColor | ||
| case .electricEel: AssetColors.Custom.electricEel.swiftUIColor | ||
| case .flamingo: AssetColors.Custom.flamingo.swiftUIColor |
There was a problem hiding this comment.
Have you changed the color assets on the iOS side?
I asked the question because Framingo colors were added for Android.
Also, ColorAsset is not registered with this name, so I would expect an error?
There was a problem hiding this comment.
In the meantime, you should rename the ColorAsset that is no longer needed.
|
Could you run ./gradlew detekt --auto-correct to fix the CI status? |
takahirom
approved these changes
Jul 10, 2024
|
Well, it seems that this is a draft PR. Are there any areas you still want to change? You can merge it whenever you're ready! |
|
Ah, I see that we need to wait for this year's API. |
mtkw0127
approved these changes
Jul 17, 2024
takahirom
changed the title
charles-b-stb
changed the title
![TimetableItemDetailScreenTest.runTest[TimetableItemDetailScreen - when server is operational - when launch - it should be appropriately accessible]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/114-roomnames/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableItemDetailScreenTest.runTest%5BTimetableItemDetailScreen%20-%20when%20server%20is%20operational%20-%20when%20launch%20-%20it%20should%20be%20appropriately%20accessible%5D_compare.png){kind=link}
![TimetableItemDetailScreenTest[TimetableItemDetailScreen - when server is operational - when launch - scroll - it should show scrolled session detail]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/114-roomnames/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableItemDetailScreenTest%5BTimetableItemDetailScreen%20-%20when%20server%20is%20operational%20-%20when%20launch%20-%20scroll%20-%20it%20should%20show%20scrolled%20session%20detail%5D_compare.png){kind=link}
![TimetableItemDetailScreenTest[TimetableItemDetailScreen - when server is operational - when launch - click bookmark - click bookmark again - it should show unbookmarked session]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/114-roomnames/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableItemDetailScreenTest%5BTimetableItemDetailScreen%20-%20when%20server%20is%20operational%20-%20when%20launch%20-%20click%20bookmark%20-%20click%20bookmark%20again%20-%20it%20should%20show%20unbookmarked%20session%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when server is operational - click timetable ui type change - it should change timetable ui type]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/114-roomnames/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20server%20is%20operational%20-%20click%20timetable%20ui%20type%20change%20-%20it%20should%20change%20timetable%20ui%20type%5D_compare.png){kind=link}
![TimetableItemDetailScreenTest[TimetableItemDetailScreen - when server is operational - when launch - it should show session detail title]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/114-roomnames/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableItemDetailScreenTest%5BTimetableItemDetailScreen%20-%20when%20server%20is%20operational%20-%20when%20launch%20-%20it%20should%20show%20session%20detail%20title%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when server is operational - click first session bookmark - it should show bookmarked session]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/114-roomnames/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20server%20is%20operational%20-%20click%20first%20session%20bookmark%20-%20it%20should%20show%20bookmarked%20session%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when server is operational - it should show timetable items]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/114-roomnames/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20server%20is%20operational%20-%20it%20should%20show%20timetable%20items%5D_compare.png){kind=link}
![TimetableItemDetailScreenTest[TimetableItemDetailScreen - when server is operational - when font scale is large - it should show small font session detail]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/114-roomnames/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableItemDetailScreenTest%5BTimetableItemDetailScreen%20-%20when%20server%20is%20operational%20-%20when%20font%20scale%20is%20large%20-%20it%20should%20show%20small%20font%20session%20detail%5D_compare.png){kind=link}
![TimetableItemDetailScreenTest[TimetableItemDetailScreen - when server is operational - when font scale is small - it should show small font session detail]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/114-roomnames/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableItemDetailScreenTest%5BTimetableItemDetailScreen%20-%20when%20server%20is%20operational%20-%20when%20font%20scale%20is%20small%20-%20it%20should%20show%20small%20font%20session%20detail%5D_compare.png){kind=link}
![TimetableItemDetailScreenTest[TimetableItemDetailScreen - when server is operational - when font scale is huge - it should show small font session detail]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/114-roomnames/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableItemDetailScreenTest%5BTimetableItemDetailScreen%20-%20when%20server%20is%20operational%20-%20when%20font%20scale%20is%20huge%20-%20it%20should%20show%20small%20font%20session%20detail%5D_compare.png){kind=link}
![TimetableItemDetailScreenTest[TimetableItemDetailScreen - when server is operational - when launch - click bookmark - it should show bookmarked session]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_feature/114-roomnames/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableItemDetailScreenTest%5BTimetableItemDetailScreen%20-%20when%20server%20is%20operational%20-%20when%20launch%20-%20click%20bookmark%20-%20it%20should%20show%20bookmarked%20session%5D_compare.png){kind=link}
|
I fixed the conflict and checked that it works by running 'sh ci.sh'. |
|
Sorry I didn't get a chance to fully review. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically updated the room names in our app for iOS and Android. This does not yet match colors, shapes or data coming from the server. These should be updated before merging.
No useful screenshots since its mismatching data.
Warning: Colors may not be updated properly (especially iOS). Data from the API has not been updated.
Issue
Overview (Required)
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)