Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the position of the loading spinner in StaffScreen #1023

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Fix the position of the loading spinner in StaffScreen #1023

merged 1 commit into from
Sep 9, 2024
+23 −25

Conversation

GGBBB2000
Copy link
Contributor

@GGBBB2000 GGBBB2000 commented Sep 9, 2024 •
edited
Loading

Issue

Overview (Required)

  • I adjusted the position of the loading spinner in StaffScreen with ContributorScreen

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After ContributorScreen

@GGBBB2000 GGBBB2000 marked this pull request as ready for review September 9, 2024 18:09
@GGBBB2000 GGBBB2000 force-pushed the fix-loading-spinner-position branch from dd26a30 to 37b3b36 Compare September 9, 2024 18:14
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 9, 2024 22:47 Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

Snapshot diff report

File name Image
StaffScreenTest[Staf
fScreen - when serve
r is operational - w
hen server is down -
when launch - it sh
ould does not show s
taff and show snackb
ar]_compare.png

takahirom
takahirom approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for your contribution!

@takahirom takahirom merged commit 2daf030 into DroidKaigi:main Sep 9, 2024
6 checks passed
@GGBBB2000 GGBBB2000 deleted the fix-loading-spinner-position branch September 9, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StaffScreen and Contributors loading positions are very different and not consistent
2 participants
@GGBBB2000 @takahirom