[feature/#245] Apply code review

DroidKaigi · Aug 12, 2024 · 71427ab · 71427ab
1 parent 5de2cff
commit 71427ab
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/.../main/java/io/github/droidkaigi/confsched/testing/robot/TimetableItemDetailScreenRobot.kt b/.../main/java/io/github/droidkaigi/confsched/testing/robot/TimetableItemDetailScreenRobot.kt
@@ -14,7 +14,7 @@ import io.github.droidkaigi.confsched.data.sessions.response.SessionsAllResponse
 import io.github.droidkaigi.confsched.designsystem.theme.KaigiTheme
 import io.github.droidkaigi.confsched.sessions.TimetableItemDetailBookmarkIconTestTag
 import io.github.droidkaigi.confsched.sessions.TimetableItemDetailScreen
-import io.github.droidkaigi.confsched.sessions.navigation.TimetableItemDestination
+import io.github.droidkaigi.confsched.sessions.navigation.TimetableItemDetailDestination
 import javax.inject.Inject
 
 class TimetableItemDetailScreenRobot @Inject constructor(
@@ -27,8 +27,8 @@ class TimetableItemDetailScreenRobot @Inject constructor(
 
     suspend fun setupScreenContent() {
         val firstSessionId = SessionsAllResponse.Companion.fake().sessions.first().id
-        robotTestRule.setContentWithNavigation<TimetableItemDestination>(
-            startDestination = { TimetableItemDestination(firstSessionId) },
+        robotTestRule.setContentWithNavigation<TimetableItemDetailDestination>(
+            startDestination = { TimetableItemDetailDestination(firstSessionId) },
         ) {
             KaigiTheme {
                 TimetableItemDetailScreen(

diff --git a/...rc/commonMain/kotlin/io/github/droidkaigi/confsched/sessions/TimetableItemDetailScreen.kt b/...rc/commonMain/kotlin/io/github/droidkaigi/confsched/sessions/TimetableItemDetailScreen.kt
@@ -40,7 +40,7 @@ import io.github.droidkaigi.confsched.sessions.component.TimetableItemDetailCont
 import io.github.droidkaigi.confsched.sessions.component.TimetableItemDetailHeadline
 import io.github.droidkaigi.confsched.sessions.component.TimetableItemDetailSummaryCard
 import io.github.droidkaigi.confsched.sessions.component.TimetableItemDetailTopAppBar
-import io.github.droidkaigi.confsched.sessions.navigation.TimetableItemDestination
+import io.github.droidkaigi.confsched.sessions.navigation.TimetableItemDetailDestination
 import io.github.droidkaigi.confsched.ui.SnackbarMessageEffect
 import io.github.droidkaigi.confsched.ui.UserMessageStateHolder
 import io.github.droidkaigi.confsched.ui.UserMessageStateHolderImpl
@@ -55,7 +55,7 @@ fun NavGraphBuilder.sessionScreens(
     onCalendarRegistrationClick: (TimetableItem) -> Unit,
     onShareClick: (TimetableItem) -> Unit,
 ) {
-    composable<TimetableItemDestination> {
+    composable<TimetableItemDetailDestination> {
         TimetableItemDetailScreen(
             onNavigationIconClick = onNavigationIconClick,
             onLinkClick = onLinkClick,
@@ -68,7 +68,7 @@ fun NavGraphBuilder.sessionScreens(
 fun NavController.navigateToTimetableItemDetailScreen(
     timetableItem: TimetableItem,
 ) {
-    navigate(TimetableItemDestination(timetableItem.id.value))
+    navigate(TimetableItemDetailDestination(timetableItem.id.value))
 }
 
 @Composable

diff --git a/...ns/navigation/TimetableItemDestination.kt → ...igation/TimetableItemDetailDestination.kt b/...ns/navigation/TimetableItemDestination.kt → ...igation/TimetableItemDetailDestination.kt
@@ -4,7 +4,7 @@ import kotlinx.serialization.SerialName
 import kotlinx.serialization.Serializable
 
 @Serializable
-data class TimetableItemDestination(
+data class TimetableItemDetailDestination(
     @SerialName("timetableItemId")
     val timetableItemId: String,
 )