Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release workflow #502

Merged
merged 16 commits into from
Oct 7, 2023
Merged

Fix release workflow #502

merged 16 commits into from
Oct 7, 2023

Conversation

Iamlooker
Copy link
Member

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Oct 7, 2023

PR Summary

  • Additional check for workflow initiation
    The workflow named build_debug.yml used to start whenever a pull request was opened or reopened. We've changed this to only initiate when a specific review is submitted. This means fewer unnecessary activations, saving resources.

  • Use of a safer secret key
    Instead of using ALIAS, we are now using the KEY_ALIAS key. This is a safer, more secure secret to use for build_debug.yml workflow.

  • Validation of Gradle Wrapper
    We've added a step in the release_build.yml workflow for validating the Gradle Wrapper using gradle/wrapper-validation-action. This ensures that safe and correct practices are followed during this step.

  • Use updated Gradle Build Action
    Release_build.yml workflow will utilize Gradle Build Action v2.9.0 for building the release APK. This ensures usage of the latest stable version with all the bug fixes and enhancements.

  • Set fixed build tools version
    The BUILD_TOOLS_VERSION variable is now set to "34.0.0". This guarantees a consistent approach during the build process.

  • Code cleanup
    Certain potentially unnecessary files like app/src/main/res/raw/keep.xml and core/common/src/main/res/raw/keep.xml have been deleted, and a line in proguard.pro file was removed. These help to keep our project clean and manageable.

  • Disable minification for release build in core data
    In core/data/build.gradle.kts file, we've set isMinifyEnabled to false for the release build type. This mainly could increase the build speed.

  • Setting new properties in Gradle
    The gradle.properties file was amended to include several new properties. These properties lead to improved build times and performance.

  • Comment added for future updates
    A comment has been added to the DefaultConfig file serve as a reminder for future updates in the release_build.yml file. This annotation promotes better maintainability of the project.

@Iamlooker Iamlooker merged commit b1a501f into main Oct 7, 2023
2 checks passed
@Iamlooker Iamlooker deleted the fix-release-workflow branch October 7, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant